Add aria-labels to PDF link annotations for accessibility#2049
Open
zhufangu wants to merge 2 commits intowojtekmaj:mainfrom
Open
Add aria-labels to PDF link annotations for accessibility#2049zhufangu wants to merge 2 commits intowojtekmaj:mainfrom
zhufangu wants to merge 2 commits intowojtekmaj:mainfrom
Conversation
Owner
|
This is REALLY sweet improvement, thank you for this!!! |
|
Is this gonna get merged? |
7c796f2 to
88585fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDF link annotations lack discernible names, causing Lighthouse accessibility warnings and poor screen reader support. (#1424)
This update adds aria-label attributes to links using overlaidText from annotation data:
setAnnotationContext/clearAnnotationContexttoLinkServiceto store annotation dataaddLinkAttributesto setaria-labelReproduce:
<a>element in the annotation layerEffect: